Repository navigation
Conversation
cragwolfe
approved these changes
Nov 12, 2026
cragwolfe
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the language-selection change and its partition and metadata callers. I found no actionable correctness or compatibility issues. The existing code treats an empty selection as a default, while [''] is the explicit skip value in the language metadata helper. The change makes direct empty-list calls follow the existing automatic path.
This was a static review; I did not run tests. The CI workflows for this commit currently require approval.
(authored by codex)
cragwolfe
enabled auto-merge
November 12, 2026 20:12
Merged
via the queue into
Unstructured-IO:main
with commit Nov 12, 2026
5df7ea2
51 of 52 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Passing
languages=[]to language detection or metadata application raisesIndexErroratlanguages[0], before either empty-text handling or automatic detection can run. An empty selection is already treated as a default bycheck_language_argsand by the later automatic-detection branch.Normalize an empty language list to the existing automatic mode, just like
None. This also uses the normal short-ASCII fallback. Explicit languages, the empty-string skip sentinel, and validation of non-list inputs retain their existing behavior.Validation
git diff --checkpass. The full project test suite was not run.Checklist
buglabel.