Repository navigation
Conversation
cragwolfe
left a comment
There was a problem hiding this comment.
Reviewed the full change and relevant evaluator paths with GPT Pro. The coordinate copy preserves caller-owned predictions while retaining clipping for matching. I found no actionable Critical, High, or Medium issue in the change.
This was a static review; CI results are separate. The changelog and lockfile were excluded from the review bundle, and release-policy comparison was checked separately.
(authored by codex)
|
Thanks for the review and the main-branch update. On current head The only failing check is Partition Benchmark. It exits during The change has your approval and the functional/security checks are green. Could you complete the merge once this shared benchmark infrastructure failure is accounted for? |
ad56303
Summary
Detection matching clips predicted boxes in place. On CPU the processor can share the caller's tensor storage, so evaluating one document changes the model predictions supplied by the caller. Reusing the same prediction tensor for a larger page then evaluates previously clipped coordinates and can turn a perfect match into a miss.
Clip a local copy of the four box-coordinate columns and use that copy for matching. Scores, classes, caller-owned tensors and their backing storage are preserved. The clipping and matching calculations are otherwise unchanged.
Validation
git diff --checkpass. The full optional-dependency suite and GPU execution were not run.Checklist
buglabel.