Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
lxml.append() moves elements, disrupting the lazy iterator. Using list() materializes all rows before the loop so none are skipped. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
When a table has HTML but takes the text-only chunking path (due to small hard_max), the deep-copied metadata retained the full original text_as_html. This would cause reconstruct_table_from_chunks to duplicate rows. Now explicitly set text_as_html=None for text-only chunks. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
…hunks Replace the parent_id linked list approach for table reconstruction with explicit chunk sequencing metadata per ML-1020: - table_id: shared UUID for all chunks from the same table - chunk_index: 0-based position in the chunk sequence - total_chunks: total number of chunks for the table Update reconstruct_table_from_chunks to group by table_id and order by chunk_index instead of walking parent_id chains. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
cragwolfe
added a commit
that referenced
this pull request
Mar 25, 2026
Fixes high-severity table reconstruction corruption by merging only top-level rows from each chunk's table HTML, preventing nested table rows from being hoisted. Adds regression coverage for nested-table HTML reconstruction. Finding reference: #4291 (comment)
Remove total_chunks per business guidance. Keep table_id and chunk_index for table reconstruction. Add tests verifying chunk sequencing metadata is set correctly on split tables and absent on unsplit tables. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This reverts commit f5d2d60.
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
cragwolfe
approved these changes
Mar 26, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 26, 2026
## Summary - Fix `_merge_table_chunks()` to merge only top-level rows from each chunk HTML table. - Prevent nested table rows from being hoisted into the reconstructed root table. - Add regression coverage to verify nested table structure is preserved. ## Finding Reference - #4291 (comment) ## Validation - `unset VIRTUAL_ENV && CI=false uv run --no-sync pytest -q test_unstructured/chunking/test_base.py -k "reconstruct_tables_from_a_mixed_element_list or preserves_nested_table_structure" --maxfail=1` - `unset VIRTUAL_ENV && CI=false uv run --no-sync pytest -q test_unstructured/chunking/test_base.py test_unstructured/chunking/test_dispatch.py --maxfail=1` - `unset VIRTUAL_ENV && uv run --no-sync python - <<'PY' from unstructured.partition.text import partition_text elements = partition_text(text="Codex initializer smoke test") assert elements, "partition_text returned no elements" print(f"partition_text smoke check passed ({len(elements)} elements)") PY` - `unset VIRTUAL_ENV && CI=false uv run --no-sync pytest -q test_unstructured/partition/test_text.py --maxfail=1` authored by codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes core table-chunking behavior by adding new metadata fields and reconstruction logic; risk is mainly around backward compatibility and correct ordering/HTML merging of split tables.
Overview
Adds end-to-end support for reassembling split tables after chunking.
TableChunknow receives stable sequencing metadata (table_id,chunk_index) when aTableis split, and a newreconstruct_table_from_chunks()helper inunstructured.chunking.dispatchgroups and mergesTableChunks back into fullTableelements (including mergedtext_as_htmlwhen available).Updates
ElementMetadatato carry the new fields (dropped during consolidation), bumps version to0.22.4, and adds unit tests covering reconstruction across mixed element streams and edge cases like missingchunk_index.Written by Cursor Bugbot for commit 1e732a3. This will update automatically on new commits. Configure here.