Replace lazyproperty with functools.cached_property#4282
Merged
KRRT7 merged 6 commits intoUnstructured-IO:mainfrom Mar 27, 2026
Merged
Replace lazyproperty with functools.cached_property#4282KRRT7 merged 6 commits intoUnstructured-IO:mainfrom
KRRT7 merged 6 commits intoUnstructured-IO:mainfrom
Conversation
cragwolfe
approved these changes
Mar 25, 2026
lazyproperty had a bug where methods returning None would re-evaluate on every access instead of caching, affecting 26 properties across the codebase. cached_property also provides faster subsequent reads as a non-data descriptor (bypasses __get__ after first access).
KRRT7
force-pushed
the
replace-lazyproperty-with-cached-property
branch
from
98445a0 to
6db80e2
Compare
…y-with-cached-property # Conflicts: # CHANGELOG.md # unstructured/__version__.py
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
Unstructured-IO:main
with commit Mar 27, 2026
7c5855b
51 of 52 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lazypropertydescriptor with stdlibfunctools.cached_propertyNonewere re-evaluated on every access instead of caching —lazyproperty.__get__usesif value is Noneto detect a cache miss, so any property that legitimately returnsNonere-runs on every accesscached_propertyis a non-data descriptor, so after first access the__dict__entry shadows the descriptor directly (plain dict lookup vs__get__call)