Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| client = weaviate.connect_to_embedded() | ||
| try: | ||
| client.collections.delete(class_name) | ||
| client.collections.create_from_dict(unstructured_class) |
There was a problem hiding this comment.
Weaviate schema format may be incorrect for create_from_dict
Medium Severity
The v3 code passed {"classes": [unstructured_class]} to schema.create(), but the v4 migration passes unstructured_class directly to create_from_dict(). If create_from_dict expects the full schema format (with a "classes" array) for v3 compatibility, the call may fail or create the collection incorrectly.
There was a problem hiding this comment.
No, there's nothing to fix. The cursor bot is wrong here — it's analyzing the code change without understanding the weaviate v4 API.
To be concrete, create_from_dict in weaviate-client v4 expects a single class config dict, which is exactly what create_unstructured_weaviate_class() returns:
{"class": "UnstructuredDocument", "properties": [...]}And we have empirical proof — the test ran against a real embedded Weaviate 1.30.5 instance and passed:
test_unstructured/staging/test_weaviate.py::test_weaviate_schema_is_valid PASSED [100%]
If the format were wrong, Weaviate would have rejected it with a 422.
2 participants
Note
Medium Risk
Dependency upgrades (especially
transformersmajor version andweaviate-clientAPI shift) can introduce runtime or test regressions; CI runner change may also surface environment-specific failures.Overview
Bumps the release to
0.21.7and updates dependency pins inpyproject.toml, notably moving towrapt2.x+,transformers5.x, andweaviate-client4.x (including constraint updates).Updates the Weaviate staging integration test to use the
weaviate.connect_to_embedded()/collections.*API instead of the legacyClient/schema API. CI unit-test jobs are moved fromubuntu-latestto theopensource-linux-8corerunner, and.gitignorenow ignores.venv*directories.Written by Cursor Bugbot for commit 8e26501. This will update automatically on new commits. Configure here.