Skip to content

ensure ml_model_loaded is false on corrupt checkpoint - #207

Closed
AaliyaKhan25 wants to merge 0 commit into
UnplugAI:devfrom
AaliyaKhan25:dev
Closed

AaliyaKhan25 wants to merge 0 commit into
UnplugAI:devfrom
AaliyaKhan25:dev

Conversation

@AaliyaKhan25

@AaliyaKhan25 AaliyaKhan25 commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Checklist

  • The issue this closes was assigned to me (see CONTRIBUTING.md)
  • This is my only open PR (one issue at a time, see CONTRIBUTING.md)
  • Target branch is dev (see BRANCHING.md)
  • cd sdk && make check-ci passes locally
  • New code has tests (every module gets a test file)
  • Public API changes are reflected in sdk/README.md / docs/
  • No secrets, internal URLs, or private paths in the diff
  • If a model wrote a meaningful part of this, I said so below (AI_POLICY.md)

Notes for reviewers

Drafted with AI assistance

@github-actions github-actions Bot added the ci Build, workflows, or tooling label Oct 11, 2026
@greptile-apps

greptile-apps Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium impact] This workflow change appears safe to merge.

Summary

This PR makes DRY_RUN an explicit "true" or "false" string in the stale-claims workflow.

  • The stale-claims workflow gives dry-run mode an explicit text value.

Reviews (1) · Last reviewed commit: "Merge branch 'UnplugAI:dev' into dev" · Reviewed by Greptile

@chiruu12

Copy link
Copy Markdown
Collaborator

This PR does not contain the #191 fix. The only change against dev is one line in .github/workflows/stale-claims.yml.

The cause is the branch. You are working on your fork's dev and merging upstream into it, so the PR carries merge commits plus be206e0 from 16 August, which is already in dev and nets to nothing. Your actual #191 work is not in any commit here.

What works better:

git checkout dev
git fetch upstream && git reset --hard upstream/dev
git checkout -b fix/191-corrupt-checkpoint
# the fix, then commit
git push origin fix/191-corrupt-checkpoint

Open the PR from that branch and leave your fork's dev alone as a clean copy of ours.

The DRY_RUN quoting change looks like a real fix on its own. Send it as its own PR against a branch and I will look at it separately.

#191 stays yours.

@greptile-apps

greptile-apps Bot commented Oct 17, 2026

Copy link
Copy Markdown

No reviewable files after applying ignore patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Build, workflows, or tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants