You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Document that scan_output_request ignores request.scanners #105
Guard.scan_request honours a per-request scanner allowlist at sdk/src/unplug/guard.py:714-723. Guard.scan_output_request has no equivalent, so the field is silently dropped on the output path.
Ignoring it is the behaviour we want. It should be stated rather than left implied.
Add a line to the scan_output_request docstring saying the field is not honoured there and why, then add a test asserting a ScanRequest with scanners=["secrets"] gives the same result as one without, so the behaviour is pinned.
Where to start: sdk/src/unplug/guard.py:614 and sdk/tests/unit/test_guard.py.
Comment here to claim it and a maintainer will assign it to you.
Activity