Skip to content

Document that scan_output_request ignores request.scanners #105

Open

Description

@chiruu12

Guard.scan_request honours a per-request scanner allowlist at sdk/src/unplug/guard.py:714-723. Guard.scan_output_request has no equivalent, so the field is silently dropped on the output path.

Ignoring it is the behaviour we want. It should be stated rather than left implied.

Add a line to the scan_output_request docstring saying the field is not honoured there and why, then add a test asserting a ScanRequest with scanners=["secrets"] gives the same result as one without, so the behaviour is pinned.

Where to start: sdk/src/unplug/guard.py:614 and sdk/tests/unit/test_guard.py.

Comment here to claim it and a maintainer will assign it to you.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationgood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions