Skip to content

[MTT-11566] [MTT-11567] Upgrade Boss Room to newest 6000.0f1 stream version (currently 6000.0.42f1) and remove errors#901

Merged
Elfi0Kuhndorf merged 3 commits intodevelopfrom
feat/upgrade-boss-room-6000.41f1
Mar 21, 2025
Merged

[MTT-11566] [MTT-11567] Upgrade Boss Room to newest 6000.0f1 stream version (currently 6000.0.42f1) and remove errors#901
Elfi0Kuhndorf merged 3 commits intodevelopfrom
feat/upgrade-boss-room-6000.41f1

Conversation

@Elfi0Kuhndorf
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf commented Mar 19, 2025 •
edited
Loading

Description

Upgrading Boss Room to newest 6000.0 stream LTS version while fixing errors and warnings.

Issue Number(s)

https://jira.unity3d.com/browse/MTT-11566
https://jira.unity3d.com/browse/MTT-11567

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@Elfi0Kuhndorf
feat: upgrade to Unity 6000.0.41f1, upgrading relevant packages, chan…
0c8c676 
…ging graphics (compatibility mode) and input system project settings to remove errors and resetting FaceInfo of fonts to remove warning
@Elfi0Kuhndorf
feat: update to 6000.0.42f1
550cf16
@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner March 19, 2025 15:03
@Elfi0Kuhndorf Elfi0Kuhndorf changed the title [MTT-11566] [MTT-11567] Upgrade Boss Room to newest 6000.0f1 stream version (currently 6000.0.4f1) and remove errors [MTT-11566] [MTT-11567] Upgrade Boss Room to newest 6000.0f1 stream version (currently 6000.0.42f1) and remove errors Mar 19, 2025
@sentinel-u3d sentinel-u3d bot requested a review from RikuTheFuffs March 19, 2025 15:50
@RikuTheFuffs
Copy link
Contributor

RikuTheFuffs commented Mar 19, 2025

No warnings appear, side note (unrelated to the PR), After entering the match and right-clicking the floor I triggered this null reference:

NullReferenceException: Object reference not set to an instance of an object
Unity.BossRoom.Gameplay.GameplayObjects.Breakable.GetTotalDamage () (at Assets/Scripts/Gameplay/GameplayObjects/Breakable.cs:121)
Unity.BossRoom.Gameplay.Actions.MeleeAction.GetIdealMeleeFoe (System.Boolean isNPC, UnityEngine.Collider ourCollider, System.Single meleeRange, System.Single meleeRadius, System.UInt64 preferredTargetNetworkId) (at Assets/Scripts/Gameplay/Action/ConcreteActions/MeleeAction.cs:136)
Unity.BossRoom.Gameplay.Actions.MeleeAction.DetectFoe (Unity.BossRoom.Gameplay.GameplayObjects.Character.ServerCharacter parent, System.UInt64 foeHint) (at Assets/Scripts/Gameplay/Action/ConcreteActions/MeleeAction.cs:88)
Unity.BossRoom.Gameplay.Actions.MeleeAction.OnStart (Unity.BossRoom.Gameplay.GameplayObjects.Character.ServerCharacter serverCharacter) (at Assets/Scripts/Gameplay/Action/ConcreteActions/MeleeAction.cs:40)
Unity.BossRoom.Gameplay.Actions.ServerActionPlayer.StartAction () (at Assets/Scripts/Gameplay/Action/ActionPlayers/ServerActionPlayer.cs:190)
Unity.BossRoom.Gameplay.Actions.ServerActionPlayer.PlayAction (Unity.BossRoom.Gameplay.Actions.ActionRequestData& action) (at Assets/Scripts/Gameplay/Action/ActionPlayers/ServerActionPlayer.cs:63)
Unity.BossRoom.Gameplay.GameplayObjects.Character.ServerCharacter.PlayAction (Unity.BossRoom.Gameplay.Actions.ActionRequestData& action) (at Assets/Scripts/Gameplay/GameplayObjects/Character/ServerCharacter.cs:273)
Unity.BossRoom.Gameplay.GameplayObjects.Character.ServerCharacter.ServerPlayActionRpc (Unity.BossRoom.Gameplay.Actions.ActionRequestData data) (at Assets/Scripts/Gameplay/GameplayObjects/Character/ServerCharacter.cs:228)
Unity.BossRoom.Gameplay.GameplayObjects.Character.ServerCharacter.__rpc_handler_1847075522 (Unity.Netcode.NetworkBehaviour target, Unity.Netcode.FastBufferReader reader, Unity.Netcode.__RpcParams rpcParams) (at <ba3a803022d7403c85287c5bab70c8a6>:0)
Unity.Netcode.RpcMessageHelpers.Handle (Unity.Netcode.NetworkContext& context, Unity.Netcode.RpcMetadata& metadata, Unity.Netcode.FastBufferReader& payload, Unity.Netcode.__RpcParams& rpcParams) (at ./Library/PackageCache/com.unity.netcode.gameobjects/Runtime/Messaging/Messages/RpcMessages.cs:75)
Rethrow as Exception: Unhandled RPC exception!
UnityEngine.Debug:LogException(Exception)
Unity.Netcode.RpcMessageHelpers:Handle(NetworkContext&, RpcMetadata&, FastBufferReader&, __RpcParams&) (at ./Library/PackageCache/com.unity.netcode.gameobjects/Runtime/Messaging/Messages/RpcMessages.cs:79)
Unity.Netcode.RpcMessage:Handle(NetworkContext&) (at ./Library/PackageCache/com.unity.netcode.gameobjects/Runtime/Messaging/Messages/RpcMessages.cs:209)
Unity.Netcode.LocalSendRpcTarget:Send(NetworkBehaviour, RpcMessage&, NetworkDelivery, RpcParams) (at ./Library/PackageCache/com.unity.netcode.gameobjects/Runtime/Messaging/RpcTargets/LocalSendRpcTarget.cs:46)
Unity.Netcode.ServerRpcTarget:Send(NetworkBehaviour, RpcMessage&, NetworkDelivery, RpcParams) (at ./Library/PackageCache/com.unity.netcode.gameobjects/Runtime/Messaging/RpcTargets/ServerRpcTarget.cs:86)
Unity.Netcode.NetworkBehaviour:__endSendRpc(FastBufferWriter&, UInt32, RpcParams, RpcAttributeParams, SendTo, RpcDelivery) (at ./Library/PackageCache/com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviour.cs:399)
Unity.BossRoom.Gameplay.GameplayObjects.Character.ServerCharacter:ServerPlayActionRpc(ActionRequestData) (at Assets/Scripts/Gameplay/GameplayObjects/Character/ServerCharacter.cs:220)
Unity.BossRoom.Gameplay.UserInput.ClientInputSender:SendInput(ActionRequestData) (at Assets/Scripts/Gameplay/UserInput/ClientInputSender.cs:257)
Unity.BossRoom.Gameplay.UserInput.ClientInputSender:PerformSkill(ActionID, SkillTriggerStyle, UInt64) (at Assets/Scripts/Gameplay/UserInput/ClientInputSender.cs:391)
Unity.BossRoom.Gameplay.UserInput.ClientInputSender:FixedUpdate() (at Assets/Scripts/Gameplay/UserInput/ClientInputSender.cs:284)

Probably m_NetworkHealthState is not there...

Anyway, this is out of the scope of the PR!

@Elfi0Kuhndorf
Copy link
Contributor Author

Elfi0Kuhndorf commented Mar 20, 2025

@RikuTheFuffs Thank you for checking it out! And I will try to reproduce the warning and log it as a new ticket if I can reproduce it.

@Elfi0Kuhndorf
Copy link
Contributor Author

Elfi0Kuhndorf commented Mar 20, 2025

It is logged now: https://jira.unity3d.com/browse/MTT-11672

@Elfi0Kuhndorf Elfi0Kuhndorf merged commit 2d9b40b into develop Mar 21, 2025
13 checks passed
@Elfi0Kuhndorf Elfi0Kuhndorf deleted the feat/upgrade-boss-room-6000.41f1 branch March 21, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikuTheFuffs RikuTheFuffs RikuTheFuffs approved these changes

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Elfi0Kuhndorf @RikuTheFuffs