[MTTB-409] Fix a Healer ability doesn't work (#893)#893
Merged
fernando-cortez merged 3 commits intodevelopfrom Dec 12, 2024
Merged
[MTTB-409] Fix a Healer ability doesn't work (#893)#893fernando-cortez merged 3 commits intodevelopfrom
fernando-cortez merged 3 commits intodevelopfrom
Conversation
Elfi0Kuhndorf
previously approved these changes
Dec 9, 2024
Contributor
Elfi0Kuhndorf
left a comment
There was a problem hiding this comment.
Looks good! Works now as expected. Thank you for fixing this!
Contributor
fernando-cortez
left a comment
There was a problem hiding this comment.
All that's left is to merge develop, and add a note in our changelog with this fix. Make sure to add the commit number to the changelog line -- the changelog should have examples of this too.
Looks great!
c8dbedd to
3dfcd47
Compare
81171b9 to
df837b1
Compare
Contributor
Author
|
Thank you both for your reviews. |
Elfi0Kuhndorf
previously approved these changes
Dec 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the PR that fixed the following issue.
To solve the above issue, I did three things.
1.
Fixed a bug where the character's orientation was flipped if the target and current location were almost the same when the skill was triggered. In that case, the character's orientation is used.
ClientInputSender.cs
2.
Despite being close enough, the Box cast would often fail depending on the angle. To compensate for this, I added the Sphere cast.
I considered creating a new Action for this, but since the logic is almost identical to the MeleeAction, I decided to only use the Sphere cast when the Radius value is set.
3.
If there are multiple targets that are checked for collisions, I've added the GetTotalDamage API to IDamagable to select the most damaged target. I felt that this prioritization was a good one, whether the MeleeAction is attack or recovery.
Note that I kept the ability to prioritize targets with hint targets for targeting.
Issue Number(s)
MTTB-409
https://jira.unity3d.com/browse/MTTB-409
Contribution checklist