fix: loading screen progress not always synced [MTT-6302]#862
Merged
LPLafontaineB merged 9 commits intodevelopfrom Aug 31, 2023
Merged
fix: loading screen progress not always synced [MTT-6302]#862LPLafontaineB merged 9 commits intodevelopfrom
LPLafontaineB merged 9 commits intodevelopfrom
Conversation
LPLafontaineB
added
2-Easy
…efore updating its networkvariable's value
Contributor
|
Codewise it looks good, but I'm currently unable to clone BossRoom due to a lack of internet data so I can't really smoke test it :C |
Contributor
|
Ok, I managed to test it and it seems to be working: on
on this branch:
(the same happens in the PostGame scene) |
RikuTheFuffs
approved these changes
Aug 23, 2023
LPLafontaineB
deleted the
fix/loading-screen-progress-not-always-synced
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the last client to connect would not see the host's loading progress bar update on loading screens. To do this, it makes sure that the NetworkedLoadingProgressTrackers are part of the DDOL scene. The PR also includes a small improvement to stop trying to update the loading progress when there is no scene load in progress.
Issue Number(s)
MTT-6302
Contribution checklist