feat: upgrade to lobby 1.1.0 [MTT-7092] [MTT-5665] [MTT-7101] [MTT-5708]#860
Merged
LPLafontaineB merged 21 commits intodevelopfrom Aug 31, 2023
Merged
feat: upgrade to lobby 1.1.0 [MTT-7092] [MTT-5665] [MTT-7101] [MTT-5708]#860LPLafontaineB merged 21 commits intodevelopfrom
LPLafontaineB merged 21 commits intodevelopfrom
Conversation
…from lobby updates from the service
This reverts commit f1893a3.
5 tasks
… at the earliest time possible
…a lobby or delete it
…ew temporary catch for edge case exception
fernando-cortez
previously approved these changes
Aug 30, 2023
Contributor
fernando-cortez
left a comment
There was a problem hiding this comment.
Not seeing the same errors as before. Looks good!
fernando-cortez
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades BR to use Lobby 1.1.0. It leverages a small new lobby feature to lock lobbies at creation and unlock them later when the server is created and Relay is ready to allow clients to join. This prevents clients from joining too early which would lead to an exception about the relay allocation not being found (while possible, this edge-case was still very unlikely, we haven't noticed it in any playtest).
This PR also fixes an issue where we would automatically send back an update request to Lobby whenever updating our local lobby data, even when that update came from the service. Since there are no changes to this data that needs to be updated during a game session, the periodic update mechanism has been removed entirely. The only updates we need to send are when setting up the relay integration, which is done when starting the host and when joining as a client.
It also removes the explicit reference we have to Wire in our package manifest, which we do not need since Wire is a dependency of Lobby.
Issue Number(s)
MTT-7092, MTT-5665, MTT-7101, & MTT-5708
Contribution checklist