Skip to content

feat: adding NetworkSimulator [MTT-6084] [MTT-6083]#843

Merged
LPLafontaineB merged 34 commits intodevelopfrom
feat/adding-netsim-v2
Jun 13, 2023
Merged

feat: adding NetworkSimulator [MTT-6084] [MTT-6083]#843
LPLafontaineB merged 34 commits intodevelopfrom
feat/adding-netsim-v2

Conversation

@LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Jun 7, 2023 •
edited
Loading

Description

This PR adds the NetworkSimulator tool to Boss Room. It can be used in the editor through the inspector, as by default, or through a new popup window which exposes some of its functionality. This window is accessible in development builds.
This PR also updates UTP to version 2.0.2, since version 2.0.0 and above is a requirement of NetworkSimulator.

This PR is based on PRs #841 and #835.

Issue Number(s)

MTT-6084 & MTT-6083

Contribution checklist

  • [n/a] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@LPLafontaineB
Upgraded UTP to version 2.0.1
fe85a3c 
(cherry picked from commit 7f058d3)
@LPLafontaineB
changelog
9037440 
(cherry picked from commit fd07a38)
@LPLafontaineB
update to utp 2.0.2
3c05204 
(cherry picked from commit f94a791)
@LPLafontaineB
Adding NetworkSimulator
48d7ff6 
* Can change preset via dropdown

(cherry picked from commit 0275af1)
@LPLafontaineB
Adding lag spike and disconnect simulation
a8edcab 
(cherry picked from commit 4b9c7c6)
@LPLafontaineB
Adding support to trigger scenarios
e1e7624 
(cherry picked from commit 61f6be6)
@LPLafontaineB
Adding custom configurations of built-in scenarios
7337f72 
(cherry picked from commit c4f798e)
@LPLafontaineB
making scenarios start automatically when selected
1720e74 
(cherry picked from commit 3f95398)
@LPLafontaineB
setting tab key to open/close netsim window
d5075f2 
(cherry picked from commit 2f916ff)
@LPLafontaineB
removing unneeded method
3ed542d 
(cherry picked from commit ae5c308)
@LPLafontaineB
Adding index entry in readme
8b91d3b 
(cherry picked from commit 7d79d78)
@LPLafontaineB
changelog entry
43a33ce 
(cherry picked from commit fab6f5c)
@LPLafontaineB
removing unnecessary using directive
ce6f921 
(cherry picked from commit a8e0adb)
@LPLafontaineB
fixing broken link in readme
dcc10ee 
(cherry picked from commit a08d5ab)
@LPLafontaineB
Updating changelog with instructions on how to bring up in-game NetSi…
94c26fd 
…m window

(cherry picked from commit f0ad3c9)
@LPLafontaineB
using ifdefs to remove netsim window from non-dev builds
8d47ea3 
(cherry picked from commit 97a669a)
@LPLafontaineB
made lag spike duration input field easier to see
407fad0 
(cherry picked from commit 92f6e23)
@LPLafontaineB
Update Startup.unity
095c0b0
@LPLafontaineB
using NetworkSimulator preset to display the ArtificialLatencyWarning
3c097e5
@LPLafontaineB
Moving NetworkSimulatorUIMediator to Utils assembly
910e3a1
@LPLafontaineB
Removing scenarios from in-game UI
e88d3c1
@LPLafontaineB
updating changelog
2fe4303
@LPLafontaineB LPLafontaineB added 1-Needs Review PR needs attention from the assignee and reviewers 2-hard This PR requires 2 reviewers labels Jun 7, 2023
@LPLafontaineB LPLafontaineB marked this pull request as ready for review June 7, 2023 17:46
@LPLafontaineB LPLafontaineB mentioned this pull request Jun 7, 2023
Closed
5 tasks
fernando-cortez
fernando-cortez previously approved these changes Jun 7, 2023
View reviewed changes
@fernando-cortez
Copy link
Contributor

fernando-cortez commented Jun 7, 2023

Can you link here the ticket for the bug encountered inside of #841? Or maybe mention it inside the summary? Looks good otherwise.

@LPLafontaineB
Copy link
Contributor Author

LPLafontaineB commented Jun 7, 2023

Can you link here the ticket for the bug encountered inside of #841? Or maybe mention it inside the summary? Looks good otherwise.

We are not yet sure it is a bug. I'll wait until discussing with the tools team tomorrow before creating the ticket. I'll adjust the summary though

jilfranco-unity
jilfranco-unity reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@jilfranco-unity jilfranco-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some visual updates to the network simulator! Here are some screenshots:

image

image

fernando-cortez
fernando-cortez reviewed Jun 9, 2023
View reviewed changes
fernando-cortez
fernando-cortez previously approved these changes Jun 9, 2023
View reviewed changes
@jilfranco-unity
Copy link
Contributor

jilfranco-unity commented Jun 9, 2023

updated the visuals, here's how they look:

2023-06-09.15-51-51.mp4

DenninDalke
DenninDalke previously approved these changes Jun 9, 2023
View reviewed changes
Copy link

@DenninDalke DenninDalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, glad you found a way to populate the Configurations collection, I missed noticing that it was a ICollection instead of a IReadOnlyCollection.

I just added a minor suggestion that should improve the code, but it's not a blocker.

@LPLafontaineB LPLafontaineB merged commit 52ae6a6 into develop Jun 13, 2023
@LPLafontaineB LPLafontaineB deleted the feat/adding-netsim-v2 branch June 13, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamuelBellomo SamuelBellomo Awaiting requested review from SamuelBellomo

@jilfranco-unity jilfranco-unity Awaiting requested review from jilfranco-unity

2 more reviewers

@DenninDalke DenninDalke DenninDalke approved these changes

@fernando-cortez fernando-cortez fernando-cortez left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1-Needs Review PR needs attention from the assignee and reviewers 2-hard This PR requires 2 reviewers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LPLafontaineB @fernando-cortez @jilfranco-unity @DenninDalke