fix: fixing connection management test [MTT-4492][MTT-6242]#826
Merged
LPLafontaineB merged 9 commits intodevelopfrom Apr 26, 2023
Merged
fix: fixing connection management test [MTT-4492][MTT-6242]#826LPLafontaineB merged 9 commits intodevelopfrom
LPLafontaineB merged 9 commits intodevelopfrom
Conversation
LPLafontaineB
added
4-On Hold
Contributor
Author
|
Marking this as "On Hold" until the update to NGO 1.4.0 is done |
fernando-cortez
previously approved these changes
Apr 26, 2023
fernando-cortez
previously approved these changes
Apr 26, 2023
fernando-cortez
added
3-Good to Merge
and removed
4-On Hold
SamuelBellomo
previously approved these changes
Apr 26, 2023
LPLafontaineB
dismissed stale reviews from SamuelBellomo and fernando-cortez
via
68fc9af
fernando-cortez
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the OnServerStopped event, added in NGO 1.4.0, to the ConnectionManager and the ConnectionStates. This allows the detection of unexpected shutdowns on the server. One of the connection management tests was ignored because there was no mechanism to detect this, but now it can be enabled.
No events were added for OnClientStarted and OnClientStopped in the ConnectionManager because for this system OnClientConnected and OnClientDisconnect are more relevant.
Issue Number(s)
MTT-4492 & MTT-6242
Contribution checklist