Merged
Conversation
LPLafontaineB
added
2-Easy
fernando-cortez
added
3-Good to Merge
and removed
1-Needs Review
(cherry picked from commit 1e97c05)
fernando-cortez
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the ConnectionMethod to simplify the reconnection flow. Now ClientReconnectingState doesn't need to know if the client was connected through Lobby or Direct IP before attempting to reconnect and instead offloads that responsibility to the ConnectionMethod that it was initially configured with. This also adds the possibility to fail early and stop retrying to reconnect if the lobby doesn't exist anymore.
Issue Number(s)
None
Contribution checklist