refactor: disconnect reason [MTT-2984] [MTT-5200]#790
Merged
LPLafontaineB merged 19 commits intochore/update-to-1.2from Dec 12, 2022
Merged
refactor: disconnect reason [MTT-2984] [MTT-5200]#790LPLafontaineB merged 19 commits intochore/update-to-1.2from
LPLafontaineB merged 19 commits intochore/update-to-1.2from
Conversation
LPLafontaineB
added
2-Easy
Contributor
Author
|
Marking this PR as DONOTMERGE until the project is updated to NGO 1.2.0 |
Assets/Scripts/ConnectionManagement/ConnectionState/HostingState.cs
Outdated
Show resolved
Hide resolved
SamuelBellomo
approved these changes
Dec 12, 2022
LPLafontaineB
added a commit
that referenced
this pull request
Dec 13, 2022
* replacing custom messaging with new disconnect reason (#790) * updating to ngo 1.2.0 * removing workaround in tests waiting two frames before disconnecting client during connection attempt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces our workaround using custom messages to send a reason to clients when their approval gets denied by the host or when the host shuts down voluntarily with the DisconnectReason feature introduced in NGO 1.2.0. This PR also updates the state diagram in architecture.md to remove the DisconnectingWithReason state that is no longer necessary.
Issue Number(s)
MTT-2984 & MTT-5200
Contribution checklist