Merged
Conversation
…ample count to a lower value now that we're using seconds and not frames.
ian-m-unity
approved these changes
Nov 28, 2022
|
Minor question, is it common to store .asset files in Git LFS? Edit: I've always thought of these as text files, but apparently some .asset files are binary 😅 |
Contributor
Author
@ian-m-unity in my experience, they are hard to merge, you usually want to treat them as binary. But it's true that diffs should be pretty small, so storing them in git LFS might be overkill? We didn't tweak this too much and just said binary==LFS. |
Contributor
Author
And yeah, even the text format is hard to merge anyway |
SamuelBellomo
added a commit
that referenced
this pull request
Dec 5, 2022
This reverts commit 5d41f26.
SamuelBellomo
added a commit
that referenced
this pull request
Dec 5, 2022
* Package bump and setting x axis to x per seconds. Had to change the sample count to a lower value now that we're using seconds and not frames. * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumped RNSM to 1.1.0
Switched x axis units to seconds instead of frames now that it's available. This means adjusting the sample count to a lower value as well to 30 seconds, since the x axis was moving too slowly.
Issue Number(s)
Contribution checklist