fix: multiple warnings on insufficient AudioSources available [MTT-2834]#785
Merged
fernando-cortez merged 5 commits intodevelopfrom Dec 15, 2022
Merged
Conversation
fernando-cortez
added
2-Easy
SamuelBellomo
previously approved these changes
Nov 17, 2022
fernando-cortez
added
3-Good to Merge
and removed
1-Needs Review
fernando-cortez
added
1-Needs Review
SamuelBellomo
previously approved these changes
Dec 15, 2022
SamuelBellomo
approved these changes
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the multiple spammed warnings you'd see during a play session regarding not having sufficient AudioSources to play looping audio clips.
Firstly, the loop audio toggle on the Tank's HitReact
AnimatorTriggeredSpecialFXelement was incorrectly enabled. This disabled playing hit react audio clips as one-shots, which 100% replicated the warnings.Secondly, the same toggle was removed on the Rogue's dash end
AnimatorTriggeredSpecialFXelement, since this did not need to be a looping audio clip. I could not reproduce the warnings once I removed this toggle.Issue Number(s)
MTT-2834
Contribution checklist