feat: host delete lobby when shutdown [MTT-4798] [MTT-4576]#772
Merged
LPLafontaineB merged 9 commits intodevelopfrom Nov 7, 2022
Merged
feat: host delete lobby when shutdown [MTT-4798] [MTT-4576]#772LPLafontaineB merged 9 commits intodevelopfrom
LPLafontaineB merged 9 commits intodevelopfrom
Conversation
LPLafontaineB
added
the
1-Needs Review
pdeschain
approved these changes
Nov 3, 2022
Contributor
pdeschain
left a comment
pdeschain
left a comment
There was a problem hiding this comment.
looking good! It makes sense to move this error handling one layer up, so that we can have more fine-grained control over how we handle them. Great job.
pdeschain
added
2-One More Review
LPLafontaineB
changed the title
fernando-cortez
approved these changes
Nov 7, 2022
fernando-cortez
added
3-Good to Merge
and removed
2-One More Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the behaviour of hosts regarding the Lobby service when they shutdown. Now, instead of leaving their lobby, they will delete it.
However, this makes it so clients who get disconnected afterwards will receive a LobbyNotFound error when trying to leave it. To prevent this, this PR also refactors how we handle Lobby exceptions, following the best practices outlined here. Now, instead of all being handled the same way in LobbyAPIInterface and always publishing errors, the responsibility is moved to LobbyServiceFacade. Since every call knows which errors to ignore and which ones to consider, it is each method's responsibility to determine how they handle LobbyServiceExceptions.
Issue Number(s)
MTT-4798 & MTT-4576
Contribution checklist