-
Notifications
You must be signed in to change notification settings - Fork 271
Closed
Description
The upcoming numpy 1.20 release will deprecate np.bool and np.float etc., see https://numpy.org/devdocs/release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated
You have some usages of this in your codebase that may throw DeprecationWarnings, we see that in the upstream-dev tests of xarray.
E.g.:
netcdf4-python/src/netCDF4/_netCDF4.pyx
Line 4559 in bcbe3a0
| totalmask = numpy.zeros(data.shape, numpy.bool) |
netcdf4-python/src/netCDF4/_netCDF4.pyx
Line 4930 in bcbe3a0
| data = numpy.array(data,numpy.float) |
I think the idea is to replace these with bool or np.bool_ (I am never entirely sure what the difference is).
Metadata
Metadata
Assignees
Labels
No labels