refactor some of the enhancement SPI lgoic and provider interface#1393
Merged
Conversation
tdrwenski
approved these changes
Oct 15, 2024
Contributor
tdrwenski
left a comment
tdrwenski
left a comment
There was a problem hiding this comment.
This looks great, thanks! Definitely makes more sense to move the enhancement name to each provider.
| @@ -130,11 +130,17 @@ public enum Enhance { | |||
| * x<0 --> 0 x>0 --> 1 | |||
| */ | |||
| ApplyClassifier, | |||
Contributor
There was a problem hiding this comment.
should we remove ApplyClassifier, ApplyNormalizer, ApplyStandardizer and instead use ApplyRuntimeLoadedEnhancements for those classes since those are being runtime loaded?
Contributor
Author
There was a problem hiding this comment.
Yeah I kinda think so too, it seems like if anyone has those attributes in their catalogs they specifically would want them to be on, can't see a reason to leave that fine-level control in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed and cleaned up the logic of the EnhancementProvider a bit
This is meant to partition things such that it's a bit safer to execute runtime-loaded Enhancements.
I'm also looking into making a Vectorize Enhancement, as mentioned in this issue, since that's something we want at CDIP as well. If/when I get it working I'll add it as an example in the docs, similar to the lighting IOSP.