Service Provider for applying enhancements#1369
Merged
haileyajohnson merged 15 commits intoJul 18, 2024
Merged
Conversation
tdrwenski
suggested changes
Jul 17, 2024
Contributor
tdrwenski
left a comment
tdrwenski
left a comment
There was a problem hiding this comment.
Overall looks good, just a few minor style issues!
tdrwenski
reviewed
Jul 17, 2024
|
|
||
| boolean appliesTo(Enhance enhance, AttributeContainer attributes, DataType dt); | ||
|
|
||
| Enhancement Create(VariableDS var); |
Contributor
There was a problem hiding this comment.
should start with lower case for method names in java, so let's make it create
haileyajohnson
force-pushed
the
ClassifierServiceProvider
branch
from
7dd1467 to
7ee573e
Compare
haileyajohnson
approved these changes
Jul 17, 2024
Contributor
haileyajohnson
left a comment
haileyajohnson
left a comment
There was a problem hiding this comment.
This looks great!
|
|
||
| boolean appliesTo(Enhance enhance, AttributeContainer attributes, DataType dt); | ||
|
|
||
| Enhancement Create(VariableDS var); |
| } | ||
|
|
||
| public static class Provider implements EnhancementProvider { | ||
|
|
Contributor
There was a problem hiding this comment.
if you make another commit, remove these spaces just to keep things clean
| @@ -290,5 +290,8 @@ public int getId() { | |||
| public Filter create(Map<String, Object> properties) { | |||
| return new ScaleOffset(properties); | |||
| } | |||
Contributor
There was a problem hiding this comment.
no need to commit changes to this file at all it seems :)
haileyajohnson
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
PR Checklist
until ready for review