Merged
Conversation
Collaborator
|
Thanks for catching this. Ideally, we would fail the build if the user explicitly set some option that |
DennisHeimbigner
added a commit
to DennisHeimbigner/netcdf-c
that referenced
this pull request
Jun 13, 2023
re: PR Unidata#2710 Apparently (see above PR) tinyxml2 now works under OS/X. So this PR is a follow on to the above PR. It modifies our OS/X github action to test tinyxml2 under OS/X.
DennisHeimbigner
approved these changes
Jun 13, 2023
DennisHeimbigner
added a commit
to DennisHeimbigner/netcdf-c
that referenced
this pull request
Jun 13, 2023
re: PR Unidata#2710 Apparently (see above PR) tinyxml2 now works under OS/X. So this PR is a follow on to the above PR. It modifies our OS/X github action to test tinyxml2 under OS/X.
petscbot
pushed a commit
to petsc/petsc
that referenced
this pull request
Dec 4, 2023
- add in fix for for OSX bug Unidata/netcdf-c#2710 - add in fix hdf5 for failure on freebsd HDFGroup/hdf5#3883 - add fix for hdf5 failure with -fp_trap failure HDFGroup/hdf5#3837
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the configuration fails on macOS with the
--disable-libxml2option:configure: error: Error: OSX requires libxml2 => --disable-dap4.The configuration fails even if we add an extra option
--disable-dap.Also, one of the two lines here is redundant: the configuration should either fail or override the user's choice and proceed. Although I personally prefer the former, the latter seems to be a common pattern in the configure script. Therefore, this MR switches from
AC_MSG_ERRORtoAC_MSG_WARNand modifies the misleading message (there is no option--disable-dap4). It also doesn't make sense to emit the message and setenable_dap4tonoif the variable is already set tono.I am not sure, whether the problem fixed with 6d44ec3 is still relevant because I have just managed to build the library with the bundled XML implementation.