Skip to content

Fix wrong header include in testing HDF5 for zlib#1731

Merged
WardF merged 1 commit intoUnidata:masterfrom
ZedThree:fix-fedora-hdf5
May 19, 2020
Merged

Fix wrong header include in testing HDF5 for zlib#1731
WardF merged 1 commit intoUnidata:masterfrom
ZedThree:fix-fedora-hdf5

Conversation

@ZedThree
Copy link
Copy Markdown
Contributor

Fedora renames the installed H5pubconf.h to allow for multi-arch installations. H5public.h will always be correct and include the correct version of H5pubconf.

@ZedThree ZedThree requested a review from WardF as a code owner May 16, 2020 11:49
@WardF WardF self-assigned this May 19, 2020
@WardF WardF added this to the 4.8.0 milestone May 19, 2020
@WardF WardF merged commit 11799a5 into Unidata:master May 19, 2020
@skosukhin
Copy link
Copy Markdown
Contributor

On the other hand, the problem with H5public.h is that it includes mpi.h, which leads to a surprise when we "disable parallel I/O for netcdf-4, even if it's enabled in libhdf5" because the requirement to provide extra preprocessor flags pointing to the location of the MPI header is not expected in this scenario.

@WardF
Copy link
Copy Markdown
Member

WardF commented Dec 23, 2024

Thank you @skosukhin, I've made a note to dig into this tomorrow and see if I can figure out how to thread this needle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants