Further improvements to datetime roundtripping #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I'm not sure why the tests take so long in CI (previous runs took 3+ hours!). The full test suite runs in about 25 seconds on my local machine. |
Collaborator
|
I have no idea why the tests are so slow all of a sudden - they run super fast on my machine too. |
Collaborator
|
I think it's the code coverage that's slowing down the CI tests. I just disabled it in the CI workflow in your branch. |
Collaborator
|
This is really nice @spencerkclark, now we are very close to microsecond roundtrip accuracy. I think all this needs is a Changelog entry. |
Collaborator
Author
|
Ah, disabling the code coverage seemed to do it, thanks! I went ahead and added a Changelog entry. Let me know if you need anything else. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forget if there was a reason we did not do this before, but this applies an approach I took in xarray (pydata/xarray#4684) to improve the accuracy of roundtripping
np.datetime64[ns]dates tocftime.datetimeobjects. The changes here would mean that we'd do our absolute best to retain an integer dtype when encoding times throughdate2num.I've included a pretty challenging test that passes on my machine;
however it may not be a valid test on 32-bit systems.Edit: I updated the PR for what I think should allow things to pass on Windows.