potential solution for roundtrip issue with microseconds (issue #187) #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 16, 2020 20:54
Collaborator
spencerkclark
left a comment
spencerkclark
left a comment
There was a problem hiding this comment.
Thanks @jswhit -- I think this makes sense. It does prevent exact roundtripping with non-microsecond units in the case when dates truly are near the second boundary -- e.g. roundtripping cftime.DatetimeNoLeap(2000, 1, 1, 0, 0, 0, 999999) with units of "days since 2000-01-01" -- but this is probably rarer than the issue in #187.
Collaborator
Author
spencerkclark
approved these changes
Jul 18, 2020
Collaborator
spencerkclark
left a comment
spencerkclark
left a comment
There was a problem hiding this comment.
Fix included for calculation of leap years when year is negative
Good catch, thanks!
Co-authored-by: Spencer Clark <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #187 and #189