-
Notifications
You must be signed in to change notification settings - Fork 447
Turbulence Fixes with xarray functionality #3881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The Codacy is upset because I use a numpy .reshape() function with 4 positional parameters ( |
a4f6baf to
8b6258c
Compare
8b6258c to
8e1fa40
Compare
dopplershift
approved these changes
Jul 28, 2025
Contributor
|
🏁 Successfully backported as #3885. 🏁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Calc
Pertains to calculations
Area: Xarray
Pertains to xarray integration
backport
Pull Requests that are automatically back-ported to the stable release
Type: Bug
Something is not working like it should
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
As described in issue #3844, when attempting to use an xarray for the calculation of turbulence kinetic energy (TKE), a ValueError was thrown because the input and output array sizes differ. The removal of the
wrap-likeargument in the@preprocess_and_wrapdecorator solved this issue. Tests have also been added to ensure functionality of TKE with xarray inputs.Checklist