add_station_lat_lon: insert columns respectfully #3852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcamron
changed the title
dopplershift
approved these changes
Jun 27, 2025
dopplershift
added
the
backport
Contributor
|
🏁 Successfully backported as #3879. 🏁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming this works across our entire matrix, this eliminates another lingering Pandas SettingWithCopyWarning that I was encountering in metpy-cookbook. Those will disappear eventually in Pandas 3.0, but this should generally be more respecting of whatever DataFrame we see. Small win of failing if latitude or longitude column already exists, as well.
Checklist