fixes issue #3535 #3549
Merged
fixes issue #3535 #3549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
anacmontoya
commented
Jun 25, 2024
dcamron
force-pushed
the
wpc-bulletin-coords
branch
from
f60da03 to
51cf86a
Compare
dcamron
added
Type: Bug
dopplershift
requested changes
Jun 25, 2024
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
The fix looks great. I'd like to go a different way with the testing; in general, it's best to always test the public API and not test internal functions.
Co-authored-by: Ryan May <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Checklist