Handle NEXRAD message 18 missing VCP info #3415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Bug
dopplershift
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| def test_msg18_novcps(): | ||
| """Check handling of message type 18 with VCP info now spares does not crash.""" | ||
| f = Level2File(get_test_data('KJKL_20240227_102059', as_file_obj=False)) |
Check warning
Code scanning / CodeQL
File is not always closed
dopplershift
force-pushed
the
fix-3413
branch
from
7735476 to
f8ac4c0
Compare
At some point the fixed VCP info in message type 18 was converted to a spare field. This still parses fine when filled with 0's, but apparently some sites are now sending out some random bytes in this location, which can break our parser.
dopplershift
force-pushed
the
fix-3413
branch
from
f8ac4c0 to
ccaf227
Compare
dopplershift
had a problem deploying
to
CodeCov
GitHub Actions
Failure
dcamron
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
At some point the fixed VCP info in message type 18 was converted to a spare field. This still parses fine when filled with 0's, but apparently some sites are now sending out some random bytes in this location, which can break our parser.
Checklist
Level2Fileopening a start L2 radar chunk file #3413