Improve isentropic interpolation #3324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally we were already using 3D pressure, so just avoid needless broadcasting outside the 1D pressure case. This paves the way for direct interpolation from e.g. sigma coords. See Unidata#3315.
dopplershift
added
Type: Bug
isentropic_interpolation_as_dataset was blindly assuming that the vertical coordinate was pressure, resulting in a confusing unit error when calling isentropic_interpolation. Check the dimensionality and raise a clearer ValueError when this is not the case. Also allow users to manually pass (as a keyword) an appropriate pressure array to use instead.
dopplershift
force-pushed
the
fix-3315
branch
from
64270d3 to
b076471
Compare
dcamron
approved these changes
Dec 15, 2023
Member
dcamron
left a comment
dcamron
left a comment
There was a problem hiding this comment.
Got to a really helpful place here, I think. Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This addresses some limitations in
isentropic_interpolationandisentropic_interpolation_as_datasetidentified in #3315, which is trying to use the functionality on WRF output natively on a sigma vertical coordinate.isentropic_interpolation_as_datasetbut check the dimensionality and issue a more usefulValueErrorisentropic_interpolationto work with a passed-in 3D pressure field, since internally we were already using a 3D pressure fieldisentropic_interpolation_as_datasetto work with data on non-pressure coordinates by accepting apressurekw-only argument in this case, which overrides using the vertical coordinate.Checklist