Make tests pass on macOS M2 #3256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets the suite passing on my M2. There are a couple contour tests that need a higher threshold for some reason, but manual inspection confirms tests are behaving as expected.
dopplershift
added
Type: Maintenance
dopplershift
changed the title
Member
Author
|
I've got two more non-image tests failing locally. |
Apparently this problematic test fails here too.
dopplershift
force-pushed
the
fix-apple-tests
branch
from
910e2e3 to
57082bb
Compare
dopplershift
force-pushed
the
fix-apple-tests
branch
from
57082bb to
3056c18
Compare
dcamron
approved these changes
Nov 1, 2023
Member
dcamron
left a comment
dcamron
left a comment
There was a problem hiding this comment.
Passes locally on my M2 as well 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This gets the suite passing on my M2. There are a couple contour tests that need a higher threshold for some reason, but manual inspection confirms tests are behaving as expected.
Need to fix a couple other tests.