define dtype for station info lat-lon #3188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcamron
reviewed
Sep 13, 2023
Member
dcamron
left a comment
dcamron
left a comment
There was a problem hiding this comment.
Thanks for throwing this together! I might run it by one of this past year's summer interns if they have time, since they had started to take a look at this before. Also offered a solution that doesn't add any new lines, but I haven't tested it across Pandas versions.
I'll come back and approve/request after running it by them!
dcamron
approved these changes
Sep 13, 2023
dopplershift
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR seeks to fix issue #2872 by explicitly declaring the type of the latitude and longitude columns of the Pandas DataFrame that gets returned when using the
add_station_lat_lonfunction.Checklist