Unit agnostic intervals for color-mapped hodographs #3054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…longer limited to instances of pint.Quantity.
…nd intervals are height data.
23ccozad
force-pushed
the
hodo-color-units
branch
from
0a26e2d to
cad27e6
Compare
23ccozad
force-pushed
the
hodo-color-units
branch
from
cad27e6 to
ef2cfbb
Compare
dopplershift
requested changes
Jun 30, 2023
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
I just noticed these as I was about to merge.
Contributor
Author
|
Cool! Didn't know we had |
Member
|
We had some issues we ran into that made things cleaner to have it (even if it's equivalent to what you wrote). Yeah, that should be the right import. |
23ccozad
force-pushed
the
hodo-color-units
branch
from
89e839a to
581e108
Compare
23ccozad
force-pushed
the
hodo-color-units
branch
from
581e108 to
4633027
Compare
dopplershift
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2404 and allows color-mapped hodographs to be colored with data that does not have units (the data is not in a pint.Quantity object).
New tests were added that specifically test color-mapped hodographs when coloring is based on data with 1) no units, 2) units of height, 3) units of pressure.
Documentation for
plot_colormapped()was improved to more clearly describe the special behavior of this function when data is given in units of height.Checklist