BUG: Raise error in moist_lapse on solver fail #3025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Bug
dopplershift
changed the title
dopplershift
force-pushed
the
fix-3004
branch
2 times, most recently
from
2f7370c to
70e64f0
Compare
The scipy solver doesn't raise an error, but has some return codes that indicate success or failure. Use these to raise an appropriate error in that case. This avoids confusing behavior in downstream calculations, like parcel_profile.
dcamron
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
The scipy solver doesn't raise an error, but has some return codes that indicate success or failure. Use these to raise an appropriate error in that case. This avoids confusing behavior in downstream calculations, like parcel_profile.
Checklist