Improve GEMPAK "thinned GFS" files #3024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that the original GEMPAK CED and MCD ([modified] cylindrical equidistant) projections, while supported by PROJ, aren't defined in the CF metadata spec (as of 1.10). This is a work-around that makes __str__ not fail, and gives a better error, when CFProjection is given a set of metadata it can't handle.
dopplershift
added
Type: Bug
dcamron
approved these changes
May 1, 2023
Member
dcamron
left a comment
dcamron
left a comment
There was a problem hiding this comment.
👍 and I'm on board with your scoping evaluation here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
The problem is that the original GEMPAK CED and MCD ([modified] cylindrical equidistant) projections, while supported by PROJ, aren't defined in the CF metadata spec (as of 1.10). This is a work-around that makes str not fail, and gives a better error, when CFProjection is given a set of metadata it can't handle.
This fixes the notebook experience so that just trying to print/take a repr doesn't result in errors. Fixing plotting is out of scope because I'm loath to try add things that aren't supported by the CF spec within our "CFProjection" class. I'm actually not even sure what the right one to use in Cartopy would be.
Checklist