Add scalloped path effect #2992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
|
@nawendt I took a bit this afternoon to reconcile your changes with the final product in #2420 and rebase on main in d209f35. I'll be glad to push that up here, but please take a look first and make sure the changes are in line with your view of your contribution. Note I haven't done any other review of functionality yet. Thanks again for this hard work! |
Contributor
Author
|
I do not see any issues. |
dcamron
force-pushed
the
feature-scallop
branch
2 times, most recently
from
d209f35 to
39b9323
Compare
Member
|
Alright, rebased and cleaned up. @nawendt be sure to stash any local changes and pull this branch first before responding to reviews or any other changes. Thanks again! |
dcamron
force-pushed
the
feature-scallop
branch
2 times, most recently
from
ab5c82f to
5dc9d57
Compare
This commit adds a path effect to make lines drawn appear to be scalloped. This was based off of modifying the matplotlib TickedStroke path effect. This style of line is often used for highlighting areas in SPC MCD products. Places it in metpy.plots.patheffects module with patches for versions of matplotlib < 3.2 in the metpy.plots._mpl module. wrong test return
Removed `withScallopedStroke` as this only added the original path to the plot. It is unlikely users will want this for this style of line. This also negates the need for the `_mpl._subclass_with_normal` monkey patch. Improved handling of control points at the end point of the path. The unit tangent vector is calculated based on if the path is a closed polygon or not. Tests were updated/added for these scenarios.
Reconcile changes in patheffects.py and test_patheffects.py after Unidata#2420. Also remove Matplotlib<3.3.0 considerations and satisfy the lint robots.
dcamron
force-pushed
the
feature-scallop
branch
from
5dc9d57 to
2874206
Compare
dopplershift
approved these changes
Apr 28, 2023
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
This looks good, pending CI being happy. Thanks @nawendt !
dopplershift
added
Type: Feature
dcamron
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1609 due to some git/github oddities.
This commit adds a path effect to make lines drawn appear to be
scalloped. This was based off of modifying the matplotlib
TickedStroke path effect. This style of line is often used for
highlighting areas in SPC MCD products.