Fix Natural Neighbor Verification example #2761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Current Image: With this PR:
which matches the v0.11 docs: |
dopplershift
added
Type: Bug
dcamron
previously approved these changes
Oct 27, 2022
Member
dcamron
left a comment
dcamron
left a comment
There was a problem hiding this comment.
Good fix! Thanks for the correct image.
During a refactor, part of a list comprehension selecting the appropriate centers was incorrectly dropped. This restores it. Flagged by e-support MPQ-167169.
The return type of this internal helper was updated in a refactor awhile ago, but the docs were not similarly updated. Also go ahead and rename a variable to make the code more clear.
dopplershift
force-pushed
the
fix-nn-example
branch
from
cbba3ec to
6584f85
Compare
Member
Author
|
Rebased on #2763 which should fix the build. Need a review to get auto-merge to pass. |
dcamron
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
During a refactor (I did) the example was broken, in terms of the visual output. A use reported this recent in esupport BQP-167169. This restores what was incorrectly dropped in the refactor, as well as fixes up a bit of debris in the relevant function.
Checklist