Fix ContourPlot default linestyle #2751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Bug
Our default was unintentionally overriding the matplotlib default, which is to (when contours are monochrome) to use solid lines for positive values and dashed lines for negative values. Change the default to `None` and better document the options.
dopplershift
force-pushed
the
declarative-dashed
branch
from
5b47f00 to
9a4eb75
Compare
kgoebber
approved these changes
Oct 20, 2022
Collaborator
kgoebber
left a comment
kgoebber
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for updating this one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Our default was unintentionally overriding the matplotlib default, which is to (when contours are monochrome) to use solid lines for positive values and dashed lines for negative values. Change the default to
Noneand better document the options.Checklist