Add vertical_dim to several index calculations #2744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Enhancement
dcamron
requested changes
Oct 18, 2022
Member
dcamron
left a comment
dcamron
left a comment
There was a problem hiding this comment.
Content looks good, just a quick style consideration!
These already supported operations on grids just fine, but they lacked the ability to control which axis was supposed to be operated upon as the vertical axis. This also adds automated xarray-based handling for this.
dopplershift
force-pushed
the
indices-vertical-dim
branch
from
18fab5c to
e00f6e5
Compare
dcamron
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This adds
vertical_dimoption tok_index,lifted_index,total_totals_index,vertical_totals,cross_totals, andsweat_index. These already supported operations on grids just fine, but they lacked the ability to control which axis was supposed to be operated upon as the vertical axis. This also adds automated xarray-based handling for this.Without this change it would assume the first dimension was always vertical.
Checklist