Interpolate broadcasting #2728
Merged
Interpolate broadcasting #2728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify call by taking just the desired shape rather than an array and number of dimensions (which were always in lock step in all usages anyway). Also rename args, add comments, and improve docs to help make it clearer what we're doing in the future.
…2714) While it worked for n-dimensional arrays, it didn't work with a set of levels that have been manually broadcast (with size 1 dimensions).
dopplershift
added
Type: Bug
dcamron
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Fixes
inteprolate_1dto properly handle the necessary broadcasting, at least for the source location (levels). I chose not to deal with broadcasting all source data since I think it's far less common and would require needing to manually do a bunch of unit manipulation.This also tries to improve
broadcast_indicesto be at lease a bit more clear what it's doing (and reduces its call complexity).Checklist