Add metadata to output of gdxarray #2691
Merged
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Unidata#2118, which allows grids obtained with the gdxarray method to work more seamlessly with the declarative plotting interface.
An existing test is modified to include a check that 'meters' have been added as the units for the x and y coordinates, but no test involving latitude and longitude are included.
dopplershift
approved these changes
Sep 22, 2022
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Looks pretty good to me. Just need to figure out why we're having fiona issues in the docs all of a sudden (I'm sure it's unrelated).
dopplershift
added
Area: IO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Fixes #2118
Checklist
(But not of the latitudes and longitudes)
(No change to the gdxarray docstring seemed warranted)