Bump image test tolerance for osx-arm64 #2688
Conversation
With matplotlib/matplotlib#23852 and conda-forge/matplotlib-feedstock#329, we can now run image tests on osx-arm64 platforms with a testing install of Matplotlib. There are some artifacts across architecture. Burying these in test tolerance allows tests to pass in a fully osx-arm64 environment. Ideally to be reduced in the future.
dcamron
added
Type: Maintenance
kgoebber
left a comment
kgoebber
left a comment
There was a problem hiding this comment.
Looks good. Reasonable bumps for images tests to accommodate osx-arm64.
Before we get this in, could you @kgoebber check this out and make sure these pass locally on your machine as well? |
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
I don't love doing this, because it makes no damned sense that the images change this much just due to changing architecture. But I don't see a reasonable alternative (we are NOT going down the route of setting architecture-dependent thresholds).
Would appreciate a confirmation from @kgoebber that this works on his system so we can completely put M1 testing issues to bed.
|
I can confirm all tests pass for the three changed files on osx-arm64 architecture. |
3 participants
These tolerance bumps allow tests to pass in an osx-arm64 environment with testing Matplotlib. Some of the artifacts do seem non-spurious, notably across some contours and barbs. A shallow debug dive into Matplotlib's quiver/barb Python code didn't yield any immediate value differences in paths, lengths, etc. Here is probably the worst offender, in
test_nws_layout; notice the edge of the farthest line on the barb:We should hopefully aim to see this resolved and trim these tolerances again in the future.