rebuild metar_parser with canopy 0.4.0 #2654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
approved these changes
Sep 8, 2022
Member
|
Test suite passes, so we should be good with this. |
dopplershift
added
Type: Maintenance
Member
|
Thanks for the help @akrherz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Whilst working on a METAR fix, I ran
canopylocally and found its generatedmetar_parser.pyhad a rather hefty diff. Perhaps it would be good to take this diff now to perhaps prevent any future PRs from having a non-atomic change included when they rerancanopytoo? Shrug.Checklist