Add numerous sounding examples #2629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
There's a bunch of linting failures still here. |
kgoebber
force-pushed
the
sounding_examples
branch
from
5b5629c to
65d73bd
Compare
dopplershift
requested changes
Sep 8, 2022
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Thanks for these. Just a few minor tweaks and edits.
dopplershift
added
Area: Examples
Member
|
Ping @kgoebber don't know if you missed me reviewing this. |
kgoebber
force-pushed
the
sounding_examples
branch
from
65d73bd to
6ca583e
Compare
Collaborator
Author
|
Yep, somehow missed this one! |
kgoebber
force-pushed
the
sounding_examples
branch
from
6ca583e to
0ed3505
Compare
dopplershift
requested changes
Sep 28, 2022
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Found a couple typos (and added a couple style suggestions because of it)
This was referenced Sep 29, 2022
kgoebber
force-pushed
the
sounding_examples
branch
from
0ed3505 to
cf985a5
Compare
dopplershift
approved these changes
Sep 30, 2022
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Looks great! Thanks for all the work helping grow our examples!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR adds a couple of additional stand alone examples of various 1D sounding calculations. This also adds a new sounding file for the example that retains the date and location information of the sounding for plotting purposes.
Checklist