Adding Raster Plot functionality #2587
Conversation
nmartinez233
force-pushed
the
raster_declarative
branch
from
bdf327d to
1bc92b9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kgoebber
left a comment
kgoebber
left a comment
There was a problem hiding this comment.
Overall this looks great! I took the PR for a spin and all seems to work well. Just a few suggestions to quell one warning and simplify the test.
The only thing missing is the baseline image for the test, which is what resulted in the failure of the test. Not too hard to create the baseline image, here is the link to the documentation that explains how to get that created.
kgoebber
left a comment
kgoebber
left a comment
There was a problem hiding this comment.
Looking good, test is now passing. Caught a couple other small things, but I think you are very close now. Might be worth adding an example as well documenting how RasterPlot works.
| @needs_cartopy | ||
| def test_declarative_raster(): | ||
| """Test making a raster plot.""" | ||
| data = xr.open_dataset(get_test_data('narr_example.nc', as_file_obj=False)) |
Check warning
Code scanning / CodeQL
File is not always closed
kgoebber
left a comment
kgoebber
left a comment
There was a problem hiding this comment.
Just a few things with the added test to make sure that the behavior is working correctly.
kgoebber
left a comment
kgoebber
left a comment
There was a problem hiding this comment.
Looks good from my end!
dopplershift
force-pushed
the
raster_declarative
branch
from
a08ad32 to
59e8324
Compare
dopplershift
added
Type: Feature
3 participants
Description Of Changes
Added a
RasterPlot()class to act as a generic interface to use Matplotlib'spcolormeshChecklist
RasterPlotinterface topcolormesh#2510