Code changes using azimuth_range_to_lat_lon #2538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dcamron
added
Type: Maintenance
dopplershift
requested changes
Jun 17, 2022
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Thanks for the contribution! This is in really good shape. I just have a few changes that I think would make it even better.
dopplershift
requested changes
Jun 29, 2022
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
Just a few things to straighten out around what we're calling ax and ax_rect, which should help with clarity.
dopplershift
previously approved these changes
Jul 7, 2022
Member
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
This looks great now. My inclination is to want to clean up the commit history to keep the NEXRAD doc update separate from the example updates, rather than a full squash.
nmartinez233
force-pushed
the
azimuth_changes
branch
from
cc5fdbc to
e179217
Compare
dopplershift
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to resolve issue #2511: