Skip to content

Conversation

@Z-Richard
Copy link
Contributor

@Z-Richard Z-Richard commented Jun 11, 2022

Description Of Changes

Add a docstring example to thickness_hydrostatic, as requested in #2277.

First-time open-source project contributor here, so I think I should start small. Let me know if any changes should be made.

Checklist

  • [ ] Closes #xxxx
  • [ ] Tests added
  • [ ] Fully documented

@Z-Richard Z-Richard requested a review from a team as a code owner June 11, 2022 19:22
@Z-Richard Z-Richard requested review from dopplershift and removed request for a team June 11, 2022 19:22
@CLAassistant
Copy link

CLAassistant commented Jun 11, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome and thanks for the contribution! This is in really good shape, I just have some minor whitespace tweaks to make the style consistent.

Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dopplershift dopplershift added Area: Docs Affects documentation Type: Enhancement Enhancement to existing functionality labels Jun 12, 2022
@dopplershift dopplershift added this to the July 2022 milestone Jun 12, 2022
@dopplershift dopplershift enabled auto-merge (squash) June 12, 2022 01:47
@dopplershift dopplershift merged commit 11b49b7 into Unidata:main Jun 12, 2022
@Z-Richard Z-Richard deleted the docstring-example branch June 12, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Docs Affects documentation Type: Enhancement Enhancement to existing functionality

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants