DRAFT: Remove unnecessary declarative layers in tests #2487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove coastlines and other geographical boundaries when not explicitly tested to avoid test breakages on underlying map updates. Reset test tolerances and commit new image baselines.
dcamron
changed the title
Member
|
Ugh that's rewriting a LOT of test images (e.g. bloating the repo). I still think this is good to move towards, but maybe just start with the ones that we can remove maps for that are failing #2478? |
Member
Author
|
Yeah, I can back it up to just those if needed. Are those the same tests that failed with the previous map update? |
Member
|
No, since the last map update was for the other side of the globe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove coastlines, other geographical boundaries from all tests that aren't explicitly testing them, let me know @kgoebber @dopplershift if this selection should change. Draft to test reset tolerances, and I can un-add some of these new baselines if they don't pass on 0-tolerance.
Checklist