Skip to content

Add zoom interpolation function #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dopplershift merged 1 commit into from
Nov 18, 2021
Merged

Add zoom interpolation function #2155

dopplershift merged 1 commit into from
Nov 18, 2021

Conversation

@kgoebber
Copy link
Collaborator

@kgoebber kgoebber commented Oct 14, 2021 •
edited
Loading

Description Of Changes

This PR stems out of the issue #2126 to implement a method for generating a finer grid spacing for data contouring purposes when using low resolution gridded output. This PR implements a version of the prototype function developed by @jthielen and also adds an attribute to the declarative syntax, with limited functionality, to make use of this new function.

Open for conversation on the naming conventions used here. I shied away from the GEMPAK language of CONTUR, as I thought that would be very confusing with our already implemented contours attributed and opted for a zoom reference, which aligns with the native SciPy function. The attribute is currently names field_zoom to imply that you are zooming the particular field through the spline interpolation. As an aside, I also refrained from using smooth, or some derivative thereof, in the name as there will be a future PR implementing one of the smoothing functions as a declarative attribute that I intend to use a derivative of that name for that attribute.

Checklist

@kgoebber kgoebber requested a review from a team as a code owner October 14, 2021 21:41
@kgoebber kgoebber requested review from dopplershift and removed request for a team October 14, 2021 21:41
@kgoebber kgoebber force-pushed the add_zoom_function branch 2 times, most recently from 7f09d50 to 76f9ae9 Compare October 15, 2021 01:52
@kgoebber kgoebber mentioned this pull request Oct 15, 2021
Merged
3 tasks
@kgoebber
Copy link
Collaborator Author

kgoebber commented Oct 15, 2021

Looks like we are failing on 3.7 minimum because of the SciPy zoom function not having the grid_mode keyword argument. What is the best way to handle this situation?

@dopplershift
Copy link
Member

dopplershift commented Oct 15, 2021

Well, looks like grid_mode was added in scipy/scipy#13095, which was released in 1.6.0 31 December 2020. That would put us at a 11 month support window on our next release if we bumped to it. So...how important is grid_mode?

@kgoebber
Copy link
Collaborator Author

kgoebber commented Oct 16, 2021

I don't think the option is critically important and have only used the default setting. We can always come back and add it in when and if is determined that it would be useful.

@dopplershift dopplershift added this to the 1.2.0 milestone Oct 20, 2021
@dopplershift dopplershift added Type: Enhancement Enhancement to existing functionality Area: Plots Pertains to producing plots labels Oct 20, 2021
@sgdecker
Copy link
Contributor

sgdecker commented Oct 21, 2021

What about contour_smooth for this one to complement field_smooth from the other PR? Or they could be verb first: smooth_contour and smooth_field which might be better from a tab-completion standpoint (you get to pick or become aware of two ways to smooth things and don't clash with contours)?

@kgoebber kgoebber force-pushed the add_zoom_function branch 6 times, most recently from f29cac7 to 0bcd333 Compare November 8, 2021 22:42
dcamron
dcamron requested changes Nov 10, 2021
View reviewed changes
Copy link
Member

@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and didn't run into any issues testing it myself. Feel free to address these minor things and then add the references between this and smooth_field to this PR while I go kick #2156 in.

dcamron
dcamron requested changes Nov 11, 2021
View reviewed changes
Copy link
Member

@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny misses; then good to go by me!

dopplershift
dopplershift reviewed Nov 15, 2021
View reviewed changes
@kgoebber kgoebber force-pushed the add_zoom_function branch 2 times, most recently from 652907c to c887732 Compare November 16, 2021 22:28
dcamron
dcamron requested changes Nov 17, 2021
View reviewed changes
Copy link
Member

@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last request, just making consistencies with the new name.

@dopplershift dopplershift merged commit 495a2db into Unidata:main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dopplershift dopplershift dopplershift approved these changes

@dcamron dcamron dcamron approved these changes

Assignees

No one assigned

Labels

Area: Plots Pertains to producing plots Type: Enhancement Enhancement to existing functionality

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

Provide a super-sampling smoother analogous to GEMPAK's CONTUR subbox factor

4 participants

@kgoebber @dopplershift @sgdecker @dcamron