Add time source functions' arguments#2295
Merged
colinator27 merged 2 commits intoUnderminersTeam:masterfrom Dec 24, 2025
Merged
Add time source functions' arguments#2295colinator27 merged 2 commits intoUnderminersTeam:masterfrom
colinator27 merged 2 commits intoUnderminersTeam:masterfrom
Conversation
|
Download the artifacts for this pull request here: GUI:
CLI: |
colinator27
approved these changes
Dec 24, 2025
Member
colinator27
left a comment
colinator27
left a comment
There was a problem hiding this comment.
I think it's fine
(Looks good, thanks!)
Contributor
Author
|
Sorry for making another change IMMEDIATELY before you replied lol |
Member
|
Also, bools are probably not required (since in modern GM versions where these functions are present, booleans can be differentiated at the bytecode level), but it won't harm anything to have them. Could be useful for some future features potentially(?), but at least right now, Underanalyzer will completely ignore the bool type on modern versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
"Continuation" of #2269
Caveats
Should be fine 🙏
Notes
I hope it's fine 🙏